fix(forum): add pagination to listForums to prevent unbounded database queries#271
Merged
Merged
Conversation
Closes omkarhole#265 listForums fetched every ForumTopic document with a single unparameterized find(). As the platform grows, each GET /api/v1/forums request loads the entire collection into memory and transmits it to the client. Add page and limit query parameters capped at a FORUM_PAGE_SIZE constant (20). The response now includes page, limit, total, and totalPages alongside the paginated forums array.
|
@anshul23102 is attempting to deploy a commit to the omkarhole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #265
listForumsfetched everyForumTopicdocument with an unparameterisedfind(). As the forum grows, eachGET /api/v1/forumsloads the full collection into memory, serialises it to JSON, and sends it to the client. This causes unbounded query time, large response bodies, and elevated heap usage under concurrent requests.What Changed
backend/controllers/forum.controller.jsonly:pageandlimitquery parameters.pagedefaults to1.limitdefaults toFORUM_PAGE_SIZE(20) and is capped at that value to prevent callers from bypassing the limit.{ forums, page, limit, total, totalPages }.countDocuments()query provides the total count for client-side pagination UI.Testing
GET /api/v1/forumsreturns at most 20 topics with pagination metadata.GET /api/v1/forums?page=2&limit=10returns the correct page.Type of Change
NSoC '26 contribution