fix(forum): add author ownership check to updateForum and deleteForum#270
Merged
omkarhole merged 1 commit intoJun 2, 2026
Merged
Conversation
Closes omkarhole#264 updateForum and deleteForum verified only that the caller was authenticated but never checked authorship. Any logged-in user could modify or delete any other user's forum topic by knowing its ID. Both handlers now fetch the topic first and compare topic.user against the verified req.user.id. A mismatch returns 403. The update path also restricts which fields can be changed to title and description, preventing the author field from being overwritten via req.body.
|
@anshul23102 is attempting to deploy a commit to the omkarhole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #264
updateForumanddeleteForuminbackend/controllers/forum.controller.jsverified only that the caller was authenticated but never checked whether the caller was the original author. Any logged-in user could modify or delete any other user's topic.What Changed
backend/controllers/forum.controller.jsonly:topic.useragainstreq.user.id.403 Not authorised.updateForumalso restricts updatable fields totitleanddescription, preventing the author field from being overwritten via the request body.Testing
403.404.Type of Change
NSoC '26 contribution