Open
Conversation
katajakasa
reviewed
Sep 22, 2025
katajakasa
reviewed
Sep 23, 2025
Nopey
force-pushed
the
adt/mod-support
branch
from
38cfbe7 to
c95cddd
Compare
Vagabond
force-pushed
the
adt/mod-support
branch
from
49fe496 to
b401e12
Compare
katajakasa
reviewed
Sep 23, 2025
katajakasa
reviewed
Sep 23, 2025
Nopey
reviewed
Oct 10, 2025
Vagabond
force-pushed
the
adt/mod-support
branch
from
b50f862 to
7f414fd
Compare
Vagabond
force-pushed
the
adt/mod-support
branch
from
192c11d to
2ab7473
Compare
Member
Author
|
I'm going to start prepping this for review, I am going to punt all the remaining tasks to future PRs, the only bug remaining I intend to fix is that there's a problem with pilot portrait alignment in tournament matches. |
Member
|
"Prevent most mod assets loading during netplay" -- most. What is allowed ? |
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
| unsigned long long entry_size = zip_entry_uncomp_size(zip); | ||
| void *entry_buf = omf_calloc(entry_size, 1); | ||
| if(zip_entry_noallocread(zip, entry_buf, entry_size) < 0) { | ||
| log_warn("failed to load %s into memory", zip_entry_name(zip)); |
katajakasa
reviewed
Feb 13, 2026
| } | ||
|
|
||
| str filename; | ||
| str_from_format(&filename, "tournaments/%s/tournament.ini", tournament_name); |
Member
There was a problem hiding this comment.
str_free() seems to be missing before the next call to str_from_format
katajakasa
reviewed
Feb 13, 2026
| // For arenas, check for 'common' for anim_ids 6 (round), 7 (number), 8 (you lose), 9 (you win), 10 (fight), | ||
| // 11 (ready), 24 (dust 1), 25 (dust 2), 26 (dust 3), 27 (match counters) | ||
|
|
||
| str_from_format(&filename, "scenes/common/%d/animdata.ini", anim_id); |
katajakasa
reviewed
Feb 13, 2026
|
|
||
| if(!allow_transparency && trans) { | ||
| log_error("PNG contained transparent pixels"); | ||
| return false; |
Member
There was a problem hiding this comment.
I think this leaks png_ptr and info_ptr
png_destroy_read_struct(&png_ptr, &info_ptr, NULL);
katajakasa
reviewed
Feb 13, 2026
|
|
||
| // Convert | ||
| af_create(a, &tmp); | ||
| af_create(a, &tmp, &fn); |
katajakasa
reviewed
Feb 13, 2026
|
|
||
| // Convert | ||
| bk_create(b, &tmp); | ||
| bk_create(b, &tmp, &fn); |
katajakasa
reviewed
Feb 13, 2026
| unsigned char *buf; | ||
| size_t len; | ||
| // check the modmanager here for a music mod | ||
| path_stem(&music, &fn); |
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
src/resources/modmanager.c
Outdated
| unsigned int count = list_size(l); | ||
| log_info("found %d music files for %s", count, name); | ||
| if(index >= count) { | ||
| log_warn("requested index %s into list of %d members", index, count); |
katajakasa
reviewed
Feb 13, 2026
| #include <confuse.h> | ||
|
|
||
| #define UPDATE_FIELD_INT(field_name, struct_field, new_value) \ | ||
| if(new_value != 0 && struct_field != new_value) { \ |
Member
There was a problem hiding this comment.
btw, I guess this means that mods cannot set field values intentionally to 0, ever ? Is that okay ?
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
katajakasa
reviewed
Feb 13, 2026
| if(!hashmap_get_str(&mod_resources, str_c(&filename), (void **)&obuf, &len)) { | ||
| assert(obuf->type == MOD_SPRITE); | ||
| log_info("found portrait for pilot %d in %s", pilot_id, trn_name); | ||
| // omf_free(pilot_data->photo); |
katajakasa
reviewed
Feb 13, 2026
Member
Author
music and arena backgrounds right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to do:
Depends on #1312 to properly display high-res assets.