Conversation
Project Setup Completed
Choosing API and metrics Data fetch Comleted
Complete Implementation of Header
Metric Details component Completed
Testing Completed
Add readme to project and Deployed via Render
TuyishimireEric
approved these changes
Oct 25, 2023
TuyishimireEric
left a comment
There was a problem hiding this comment.
Status: APPROVED 🟢
Hi @ometman 👋 👋
I'm @TuyishimireEric, Your code reviewer,
Good job on implementing the project requirements! 🥇
Your project is complete! There is nothing else to say other than... it's time to merge it 🦾
Congratulations! 🎉
Highlight 👍
✅ Organized codebase. 👍
✅ Gitflow is followed. 👍
✅ Professional README file. 👍
✅ No linter errors. 👍
✅ PR has a good title and summary. 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I have completed the React-Redux Capstone project:
I chose a World Bank economic indicator API for West African/Sub-Saharan African Countries
Design has been followed as on Behance, for Typography, Layout and Color.
Acknowledgement is given to Nelson Sakwa in the Readme for the design
Britainica is also mentioned for the map.
On loading, the home page shows names of countries and capital city parameters from the API.
On clicking the right-arrow button, detailed metrics is show about that countries standing.
Back and forward buttons are implemented for navigation, including breadcrumbs.
Unit test is created for each component
Test is created using React Testing Library with Jest
Create integration tests for your application using the React Testing Library.
Mocking is implemented to test data fetch and store connection.
The project is a single-page application (SPA) built with React and Redux.
The data retrieved from the API is stored in the Redux store.
Data is retrieved by filtering data in the store state
Each page has a unique route
The Project has been deployed on Render and the live link is added to the Readme.
A detail Readme is added
Presentation on demo video is added.