Skip to content

Handle wasm archive target names#10

Closed
danielraffel wants to merge 1 commit into
olilarkin:mainfrom
danielraffel:pr/wasm-archive-targets
Closed

Handle wasm archive target names#10
danielraffel wants to merge 1 commit into
olilarkin:mainfrom
danielraffel:pr/wasm-archive-targets

Conversation

@danielraffel

@danielraffel danielraffel commented May 23, 2026

Copy link
Copy Markdown
Contributor

Newer Skia wasm builds expose archive targets with a .wasm.a suffix, while this package still publishes the usual lib*.a filenames.

This keeps those two names separate:

  • Ninja builds the wasm-specific target name
  • packaging still writes the existing library filename

The existing Windows .lib target-name rule now goes through the same helper, so the platform-specific naming rules are in one place.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@danielraffel

Copy link
Copy Markdown
Contributor Author

I noticed #7 already includes the wasm target-name handling, so I'm closing this one to avoid duplicating the same change. The branch can still be useful as a small reference if you want the wasm bit separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant