Open
Conversation
The spec fails validation with Redocly CLI due to structural issues: 1. OAuth2ClientJsonSigningKeyRequest: `discriminator` and `required` were incorrectly nested inside `properties` instead of at the schema level 2. EnhancedDynamicNetworkZone: `include` and `exclude` properties used array syntax (`- $ref:`) instead of direct reference syntax (`$ref:`) 3. OAuth2ClientJsonWebKeyECRequest: typo `nullabe` corrected to `nullable` Validation command: `npx @redocly/cli lint api.yaml` Before: 6 errors, 1218 warnings After: 0 errors, 1199 warnings Fixes okta#1672
mraible
force-pushed
the
fix-openapi-spec-validation-errors
branch
from
7ce72b5 to
e7caf4a
Compare
Contributor
|
Hi @mraible, thanks for your PR! Could you please complete the CLA and share it with us? Once that’s done, we can go ahead and merge it. |
Contributor
Author
|
@prachi-okta I worked at Okta for 7 years, does that help bypass the CLA? If not, can I do it online? I don't have access to a printer right now. |
Upstream fixed the EnhancedDynamicNetworkZone include/exclude properties using allOf with descriptions. Took upstream's version as it's more complete and also resolves the structural issue.
mraible
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI spec at
src/swagger/api.yamlhas a typo that causes a validation error.This is a follow-up to #1604 and fixes #1672.
Fix
OAuth2ClientJsonWebKeyECRequest (line 70291): typo
nullabecorrected tonullableValidation Results
Before:
After:
Reproduction