-
Notifications
You must be signed in to change notification settings - Fork 0
Assignment 1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Assignment 1 #1
Conversation
juliagallucci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're close! For part B, the function currently always lowercases both words before comparing, this means it doesn’t actually perform a case-sensitive check when is_case_sensitive=True; consider applying .lower() only when case sensitivity is set to False. Please revise
|
Hi Julia,
Thank you so much and I am sorry for the late response. I have revised my assignment. Please let me know if now its okay
Ofir
…________________________________
From: juliagallucci ***@***.***>
Sent: Wednesday, October 22, 2025 9:36 AM
To: ofirsivan/python ***@***.***>
Cc: Ofir Sivan ***@***.***>; Author ***@***.***>
Subject: Re: [ofirsivan/python] Assignment 1 (PR #1)
@juliagallucci requested changes on this pull request.
You're close! For part B, the function currently always lowercases both words before comparing, this means it doesn’t actually perform a case-sensitive check when is_case_sensitive=True; consider applying .lower() only when case sensitivity is set to False. Please revise
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BXK7NJMIUYRA4HSNDTOKJHT3Y6B7BAVCNFSM6AAAAACJZ6YCQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNRVHA2DQNBTGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
juliagallucci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re close — but right now your code doesn’t actually use the results of the sorted() comparisons to decide if the words are anagrams. The comparison lines run but their results aren’t stored or returned, so the function always returns True or False regardless of whether the words match. please revise
|
Hi Julia,
Thank you so much for your help. I will start working on it right away.
I would like to request a 24-hour extension for today’s submission. Should I also inform Kaylie about this?
I apologize for the delays; I have been struggling with an ongoing illness since last Monday, which has really slowed me down.
Best,
Ofir
…________________________________
From: juliagallucci ***@***.***>
Sent: Monday, October 27, 2025 1:51 PM
To: ofirsivan/python ***@***.***>
Cc: Ofir Sivan ***@***.***>; Author ***@***.***>
Subject: Re: [ofirsivan/python] Assignment 1 (PR #1)
@juliagallucci requested changes on this pull request.
You’re close — but right now your code doesn’t actually use the results of the sorted() comparisons to decide if the words are anagrams. The comparison lines run but their results aren’t stored or returned, so the function always returns True or False regardless of whether the words match. please revise
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BXK7NJMHECGRWVPRQO3Y6433ZZLSXAVCNFSM6AAAAACJZ6YCQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOBUG42TEOJXGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
juliagallucci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're close! For part b, you are inverting the intended behavior of is_case_sensitive. You should first check case sensitivity, then run the conditional lines of code accordingly. Please revise
|
Thank you!
I am revising it now
Ofir
…________________________________
From: juliagallucci ***@***.***>
Sent: Wednesday, October 29, 2025 3:49 PM
To: ofirsivan/python ***@***.***>
Cc: Ofir Sivan ***@***.***>; Author ***@***.***>
Subject: Re: [ofirsivan/python] Assignment 1 (PR #1)
@juliagallucci requested changes on this pull request.
You're close! For part b, you are inverting the intended behavior of is_case_sensitive. You should first check case sensitivity, then run the conditional lines of code accordingly. Please revise
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BXK7NJO4QG67UVYIEPPES6332EK5BAVCNFSM6AAAAACJZ6YCQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOJVHA2DMNRTGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
…ailed explanations. Thank you for all the help, I have learned a lot!
juliagallucci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding a code to define a function
What did you learn from the changes you have made?
How to work systematically with conditional, the syntax and operation mechanism of "lower" string method and the operation mechanisms of sorted
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
yes- to define the string as a list and formulate a set of conditionals - which appeared to be very cumbersome
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I revise all the slides and the recorded lectures
How were these changes tested?
Jupiter notebook cell by cell [in my local machine] f
A reference to a related issue in your repository (if applicable)
Checklist