Skip to content

Conversation

@ofirsivan
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding a code to define a function

What did you learn from the changes you have made?

How to work systematically with conditional, the syntax and operation mechanism of "lower" string method and the operation mechanisms of sorted

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

yes- to define the string as a list and formulate a set of conditionals - which appeared to be very cumbersome

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I revise all the slides and the recorded lectures

How were these changes tested?

Jupiter notebook cell by cell [in my local machine] f

A reference to a related issue in your repository (if applicable)

Checklist

  • [V ] I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close! For part B, the function currently always lowercases both words before comparing, this means it doesn’t actually perform a case-sensitive check when is_case_sensitive=True; consider applying .lower() only when case sensitivity is set to False. Please revise

@ofirsivan
Copy link
Owner Author

ofirsivan commented Oct 24, 2025 via email

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re close — but right now your code doesn’t actually use the results of the sorted() comparisons to decide if the words are anagrams. The comparison lines run but their results aren’t stored or returned, so the function always returns True or False regardless of whether the words match. please revise

@ofirsivan
Copy link
Owner Author

ofirsivan commented Oct 27, 2025 via email

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close! For part b, you are inverting the intended behavior of is_case_sensitive. You should first check case sensitivity, then run the conditional lines of code accordingly. Please revise

@ofirsivan
Copy link
Owner Author

ofirsivan commented Oct 30, 2025 via email

…ailed explanations. Thank you for all the help, I have learned a lot!
Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants