luleg - Technical Training - Creation of the Real Estate Module by Astremy · Pull Request #1176 · odoo/tutorials

Astremy · 2026-02-16T14:28:44Z

Here is my progress on the Technical training

Don't hesitate to give me feedbacks about what I could improve.

robodoo · 2026-02-16T14:28:47Z

AlessandroLupo

Nice work! 👍

Ideally, we should have a single commit per tutorial chapter. But I see that you introduced some code in advance (for example, EstateTagCategory is introduced in chapter 7, right?). Is there a specific reason for this? As a git exercise, you could try to move some of this content to the right commit when you reach the correct chapter.

It is very good that you fixed the styling error. You could try to do it in the already existing commits instead of adding a new one.

Depending on your confidence with git, this may be boring or may be very interesting. Feel free to ask for help if you need :)

Astremy · 2026-02-17T08:14:08Z

Thank you for the feedbacks!
The thing is, I just tried to make the structure of the model as close as possible to first image of chapter two (I didn't evn notice the other images before now, so... I could put even more fields into my model). I didn't look at the tutorial for that, I just went and dug in odoo's code. In the same way, it seems like I also did the chapter 10 part before finishing chapter 2...

I kinda just go and find what I need for what I want to do and do it ^^'

Well, about moving parts of the code... it would probably be pretty annoying, I know a bit of git but in no way in hell do I already know how to do that in particular (moving code around commits) (especially now that it's pushed and assuming I don't force push, which I would love not to do).

AlessandroLupo · 2026-02-17T16:21:42Z

Good job 👍

I see your runbot is red, please try to fix the problems and make it green. It's just a styling error and a problem about an invisible element, feel free to ask for help :)

… notebook to the form with more infos.

…y2one, addition of property offer and completion of the property page

Automatic calculation of validity/deadline, total area/living area/garden area, and best price

… display

AlessandroLupo

Nice work with the currency conversion part. Just a few minor comments 👍

AlessandroLupo · 2026-02-20T08:22:25Z

estate/models/estate_property_offer.py

+    property_type_id = fields.Many2one("estate.property.type", string="Property Type", related="property_id.property_type_id")

-    # Beginning of the deadline part
+    # Deadline Part


It is a good practice to leave comments on your code. But consider cleaning them a bit. In this case, you have "deadline part", then a bit after you have "beginning of the deadline part" and then "end of the deadline part". In most of the cases, commenting only the beginning of a block is enough :)

AlessandroLupo · 2026-02-20T08:23:46Z

estate/security/ir.model.access.csv

 access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
-access_estate_tag,access_estate_tag,model_estate_tag,base.group_user,1,1,1,1
-access_estate_tag_category,access_estate_tag_category,model_estate_tag_category,base.group_user,1,1,1,1
+access_estate_tag,access_estate_tag,model_estate_tag,base.group_user,1,1,1,1


Empty line is missing at the end of file ;)

AlessandroLupo · 2026-02-20T08:40:13Z

estate/views/estate_property_views.xml

+                                    <field name="translated_price" options="{'currency_field': 'property_currency_id'}" />
+                                    <field name="price" options="{'currency_field': 'currency_id'}" />


I found a bit confusing that both "Price" and "Original price" are shown here. Also, "price" is shown without currency symbol. Maybe consider showing only the original price?

What's shown on top is the best offer in the same currency as the expected sell price, so, for commercials to be able to know which offer is the best one without having to do the conversion themselves, I need to show the translated price next to the offered price.

You could say that you don't need it since the offers are ordered related to the translated price, but then how do you know how much less would be the second best offer?

Oh okay now I see your point. You could use something like "price in the local currency" just to make it clearer, but that's up to you 👍

AlessandroLupo

Good job. You're not the first one having a problem with the one2many domain in ResUsers, see my comment :D

AlessandroLupo · 2026-02-20T12:58:38Z

estate/models/estate_property.py

+    @api.ondelete(at_uninstall=False)
+    def _unlink_except_if_advanced_stage(self):
+        for property in self:
+            if not property.stage in ["new", "cancelled"]:


or if property.state not in [....]

AlessandroLupo · 2026-02-20T13:09:41Z

estate/models/res_users.py

+
+    # Domain doesn't work
+    property_ids = fields.One2many("estate.property", "seller_id", string="Properties List",
+    domain="[('available_from', '<=', 'today'), ('stage', '!=', 'cancelled'), ('stage', '!=', 'sold')]")


Domain doesn't work because it is supposed to be a list, not a string :D
Also consider doing ('stage', 'not in', ('cancelled', 'sold'))

AlessandroLupo · 2026-02-20T13:13:03Z

estate/views/res_user_views.xml

+            <xpath expr="//notebook" position="inside">
+                <page string="Real Estate Properties">
+                    <!-- The filter doesn't work, I'm too sick for this. To fix later -->
+                    <field name="property_ids" readonly="1" domain="[('available_from', '&gt;=', 'today'), ('stage', '!=', 'cancelled'), ('stage', '!=', 'sold')]"/>


I think you won't need the domain here anymore after having fixed the one in ResUsers

Astremy added 2 commits February 16, 2026 14:14

[ADD] Real Estate: Creation of the module definition

9658532

[IMP] Real Estate: Add basic property model

64e5ae6

Astremy closed this Feb 16, 2026

Astremy deleted the 19.0-creation-estate-module-luleg branch February 16, 2026 14:29

Astremy restored the 19.0-creation-estate-module-luleg branch February 16, 2026 14:30

Astremy reopened this Feb 16, 2026

AlessandroLupo self-requested a review February 16, 2026 15:40

AlessandroLupo reviewed Feb 16, 2026

View reviewed changes

Astremy force-pushed the 19.0-creation-estate-module-luleg branch 2 times, most recently from 8347447 to 0fedb0f Compare February 18, 2026 10:34

Astremy added 4 commits February 18, 2026 11:43

[IMP] real estate: Set base data and access rights

95a5568

[IMP] Real Estate: Add estate application page with list and form view.

63a9396

[IMP] Real estate: Improvement of the property model, addition of the…

68e374f

… notebook to the form with more infos.

[IMP] Real Estate: Change of property types from a selection to a man…

adf087f

…y2one, addition of property offer and completion of the property page

Astremy force-pushed the 19.0-creation-estate-module-luleg branch from 0fedb0f to adf087f Compare February 18, 2026 10:45

[IMP] Real Estate: Added offers and automatic calculations

48de967

Automatic calculation of validity/deadline, total area/living area/garden area, and best price

Astremy force-pushed the 19.0-creation-estate-module-luleg branch from 29b5cc1 to 48de967 Compare February 18, 2026 15:24

Astremy added 2 commits February 19, 2026 10:47

[IMP] Real Estate: Setup of validation

03a702a

[IMP] Real Estate: Added some constraints to the price

4d76898

Astremy force-pushed the 19.0-creation-estate-module-luleg branch from c98800a to 4d76898 Compare February 19, 2026 11:26

[IMP] Real Estate : Addition of a smart buttons and changes in offers…

c731814

… display

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

[IMP] Added integration to res.user

bb74433

Astremy force-pushed the 19.0-creation-estate-module-luleg branch from 3db0868 to bb74433 Compare February 20, 2026 12:32

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

		<field name="translated_price" options="{'currency_field': 'property_currency_id'}" />
		<field name="price" options="{'currency_field': 'currency_id'}" />

Comments

Conversation

Astremy commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Astremy commented Feb 17, 2026

Uh oh!

AlessandroLupo commented Feb 17, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants