Sébastien Laurent commit tutorials Chapter 1 -> 4 by selau-odoo · Pull Request #1175 · odoo/tutorials

selau-odoo · 2026-02-16T13:46:09Z

Please accept it

robodoo · 2026-02-16T13:46:12Z

AlessandroLupo

Nice work! Just a few comments 👍

estate/models/__init__.py

AlessandroLupo · 2026-02-16T15:33:37Z

estate/models/estate_property.py

+    _description = "This is my first model"
+
+    name = fields.Char(required=True)
+    description = fields.Text()


It is not mandatory, but if you want you can add the string argument to every fields method, to describe that field (like you did for garden_orientation)

AlessandroLupo · 2026-02-16T15:35:32Z

estate/__manifest__.py

@@ -0,0 +1,6 @@
+{
+    'name': 'Estate',


If you don't specify a license, you will get a warning in your console when you launch Odoo

AlessandroLupo · 2026-02-16T15:37:26Z

estate/__manifest__.py

+    'name': 'Estate',
+    'depends': ['base'],
+    'application': True,
+    'data': ['security/ir.model.access.csv']


Here you refer to the file ir.model.access.csv, but this file is created in the next commit. Try to move this line to the next commit too. (Feel free to ask for help with git if you need 😄 )

AlessandroLupo

Nice job! 👍
I added just a small comment. Also, note that your runbot is red, try to make it green by amending your commit. Let me know if you need help with git! ;)

AlessandroLupo · 2026-02-18T08:45:13Z

estate/views/estate_property_views.xml

+                            <group>
+                                <field name="offer_ids" string="Offers"/>
+                            </group>


At the moment you are getting the word "Offers" on the side of your offer list (see image).

This happens because you are wrapping offer_ids, which is One2Many, with a group tag. If this is not wanted, you can just remove the group tags. ;)

AlessandroLupo · 2026-02-18T09:00:15Z

estate/models/estate_property_offer.py

+
+class EstatePropertyOffer(models.Model):
+    _name = "estate.property.offer"
+    _description = "This is my fourth model"


Of course this is just a tutorial and it's ok to use whatever string you want. But for the future, consider that _description should be a string describing the model (for example, "Estate Property Offer"). This sting may even be shown to the user in some cases. 😄

…rties and offers. And onchange method

AlessandroLupo · 2026-02-19T13:24:15Z

estate/views/estate_property_offer_views.xml

+    <!-- <record id="estate_property_offer_view_form" model="ir.ui.view">
        <field name="name">estate.property.offer.view.form</field>
        <field name="model">estate.property.offer</field>
        <field name="arch" type="xml">
            <form string="Estate property offers">
                <group>
                    <field name="price" string="Price"/>
-                    <field name="status"/>
                    <field name="partner_id" string="Partner"/>
                    <field name="property_id" string="Property"/>
                    <field name="validity"/>
                    <field name="date_deadline"/>
                </group>
            </form>
        </field>
-    </record>
+    </record> -->


You may want to remove from the history the commented snippets of code at some point. ;)

estate/models/estate_property_offer.py

…ab on the form of the users

AlessandroLupo

Good work 👍 , just a couple of minor comments

AlessandroLupo · 2026-02-20T09:49:02Z

estate/models/res_users.py

+class ResUsers(models.Model):
+    _name = "res.users"
+    _description = "Adding fields for the user model"
+    _inherit = ['res.users']


Since we just want to extend the ResUser model, you could just use _inherit = 'res.users', without defining _name or _description.

AlessandroLupo · 2026-02-20T09:49:56Z

estate/models/res_users.py

+        'estate.property',
+        'salesman_id',
+        string="Estates",
+        domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]",


This domain is not going to work. It must be an actual list: domain=['|', ('state', '=', 'new'), ('state', '=', 'offer_received')] (not a string). ;)

selau-odoo force-pushed the 19.0-tutorials-selau branch 2 times, most recently from 3b44f61 to 8c98d46 Compare February 16, 2026 14:16

AlessandroLupo self-requested a review February 16, 2026 15:29

AlessandroLupo reviewed Feb 16, 2026

View reviewed changes

[ADD] module: Estate module. Chapter 1->3

01338d7

AlessandroLupo reviewed Feb 18, 2026

View reviewed changes

selau-odoo force-pushed the 19.0-tutorials-selau branch 5 times, most recently from dcf41e8 to 1ab4e50 Compare February 18, 2026 09:56

[REF] Adding custom views to estate module

6bcf6d1

selau-odoo force-pushed the 19.0-tutorials-selau branch from 1ab4e50 to 6bcf6d1 Compare February 18, 2026 09:56

[REF] Chapter 8 done. Added some compute methods for the estate prope…

c41b9cd

…rties and offers. And onchange method

selau-odoo force-pushed the 19.0-tutorials-selau branch from c59884b to c41b9cd Compare February 18, 2026 10:13

selau-odoo added 2 commits February 18, 2026 13:15

[REF] Adding Sold, cancelled, accept offer and refuse offer buttons

519fdbd

[REF] Creating constraints on the attributes

99f8f4c

selau-odoo force-pushed the 19.0-tutorials-selau branch from 676ae71 to 99f8f4c Compare February 18, 2026 14:30

AlessandroLupo reviewed Feb 19, 2026

View reviewed changes

selau-odoo force-pushed the 19.0-tutorials-selau branch 3 times, most recently from b436c8f to 8898583 Compare February 20, 2026 08:15

selau-odoo added 2 commits February 20, 2026 10:23

[IMP] Chapter 11: Add sprinkles

2a6ac3b

[REF] Chapter 12 Adding a field to the res.users model and adding a t…

b410971

…ab on the form of the users

selau-odoo force-pushed the 19.0-tutorials-selau branch from 8898583 to a694698 Compare February 20, 2026 09:24

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

[IMP] Creating an invoice when solding an estate

53f5643

selau-odoo force-pushed the 19.0-tutorials-selau branch from a694698 to 53f5643 Compare February 20, 2026 10:05

[IMP] Adding a kanban view for the estate module

ad54944

Comments

Conversation

selau-odoo commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants