Tutorials by coder-odoo · Pull Request #1174 · odoo/tutorials

coder-odoo · 2026-02-16T13:44:47Z

No description provided.

robodoo · 2026-02-16T13:44:50Z

AlessandroLupo

Nice work! :D I added a couple of comments. Please make sure that your commit messages follow the guidelines. 👍

AlessandroLupo · 2026-02-16T13:59:07Z

estate/models/__init__.py

+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import estate_property


Remember to add an empty line at the end of each file ;)

estate/models/estate_property.py

estate/__manifest__.py

AlessandroLupo

Thanks for the changes, it looks fine now! 👍

…erience

AlessandroLupo

Good job, it's nice that you got a green runbot. 👍 I added a couple of minor comments.
As a git exercise, you could try to do an interactive rebase and leave only one commit per chapter (you could also add the chapter number to the commit messages). To achieve this, you could just squash the commit fixing the runbot with the previous commit. Let me know if you need support with git!

AlessandroLupo · 2026-02-18T09:35:00Z

estate/views/estate_list_views.xml

+        <field name="arch" type="xml">
+            <list string="Properties">
+                <field name="name"/>
+                <field name="tag_ids"/>


You could use widget="many2many_tags" to have the actual tag names displayed on each line ;)

AlessandroLupo · 2026-02-18T09:36:09Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_property_type,access_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_property_tag,access_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_property_offer,access_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


No empty line at the end of file 😄

AlessandroLupo · 2026-02-18T09:39:37Z

estate/models/estate_property_type.py

+
+class EstatePropertyType(models.Model):
+    _name = "estate.property.type"
+    _description = "A table for estate properties types"


Nitpick: briefly explore the Odoo codebase searching for _descrption. You will see that we tend to use a more concise style. I would use something like "Estate Property Type".

AlessandroLupo

Good job with the git exercise! 👍

AlessandroLupo · 2026-02-19T10:14:04Z

estate/views/estate_list_views.xml

        <field name="model">estate.property</field>
        <field name="arch" type="xml">
-            <list string="Properties">
+            <list string="Properties" decoration-success="state == 'offer_received' or state == 'offer_accepted'" decoration-bf="state == 'offer_accepted'" decoration-muted="state == 'sold'">


You could also use decoration-success="state in ('offer_received', 'offer_accepted')"

AlessandroLupo · 2026-02-19T13:10:35Z

estate/models/res_users.py

Try to search the Odoo codebase for the line _inherit = 'res.users'. You will see what is the common style for inherited classes. The class should be named "ResUsers" and the file should be named "res_users". ;)

AlessandroLupo

Good job! 👍

AlessandroLupo · 2026-02-20T08:51:35Z

estate_account/models/estate_property.py

+from odoo import models
+
+
+class EstatePropertyInherited(models.Model):


Nitpick: the conventional name here would be EstateProperty (no need to add "Inherited") ;)

AlessandroLupo

Nice work 👍

AlessandroLupo · 2026-02-20T12:32:03Z

awesome_owl/static/src/card/card.xml

+                <h5 class="card-title"><t t-esc="props.title"/></h5>
+                <p class="card-text">
+                    <t t-out="props.content"/>


You could also do:

<h5 class="card-title" t-out="props.title"/> <p class="card-text" t-out="props.content"/>

AlessandroLupo · 2026-02-20T12:36:05Z

awesome_owl/static/src/counter/counter.js

+        if (this.props.onChange) {
+            this.props.onChange();
+        }


Here you could use optional chaining: this.props.onChange?.().

AlessandroLupo · 2026-02-20T12:51:15Z

awesome_owl/static/src/todo/todo_list.js

+    }
+
+    addTodo(ev) {
+        if (ev.keyCode === 13 && ev.target.value != "") {


You could also use ev.key === "Enter" (see here). keyCode is deprecated

AlessandroLupo · 2026-02-20T12:54:51Z

awesome_owl/static/src/todo/todo_list.js

+    static template = "awesome_owl.todo_list";
+
+    setup() {
+        this.todos = useState([]);


Here I would do this.state = useState({todos: []}), and later access the todos array using this.state.todos, so it is clear that todos is in the component state.

AlessandroLupo

You're doing well! Just two comments

AlessandroLupo · 2026-02-20T15:02:27Z

awesome_owl/static/src/card/card.js

    static props = {
-        title: String,
-        content: String,
+        title: { type: String },


Just to be clear, title: String was fine too (it is assumed implicitly that you are defining the type), but feel free to use the style you prefer 👍

AlessandroLupo · 2026-02-20T15:31:57Z

awesome_owl/static/src/todo/todo_list.js

+    removeTodo = (todoId) => {
+        const index = this.todos.findIndex((t) => t.id === todoId);
+        if (index > 0) {
+            this.todos.splice(index, 1);
+        }
+    }


Will this work if we try to remove the first element in the todo list (index 0)?

AlessandroLupo self-requested a review February 16, 2026 13:56

AlessandroLupo requested changes Feb 16, 2026

View reviewed changes

[ADD] estate: fix errors in the previous commit

34e5c4f

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 91e995b to 34e5c4f Compare February 16, 2026 15:01

AlessandroLupo reviewed Feb 16, 2026

View reviewed changes

coder-odoo added 5 commits February 16, 2026 16:30

[IMP] estate: Adding access rights for the group user

f6b71c7

[IMP] estate: Adding default UI

ae8e6d9

[IMP] estate: Adding custom form/list and a search engine

04a9478

[IMP] estate: Adding Tags, offers, property type, salesman and buyer

c2bb0ee

[IMP] estate: Adding computed/onchange fields to improve the user exp…

3d095b8

…erience

AlessandroLupo reviewed Feb 18, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch from e9bada5 to f8501db Compare February 19, 2026 08:22

coder-odoo added 3 commits February 19, 2026 09:28

[IMP] estate: Adding Sold/Cancel button and Accepted/Refused offer

bca84cb

[IMP] estate: Make sure that the data stays consistent

799b2e2

[IMP] estate: Add The Sprinkles

d31c05f

coder-odoo force-pushed the 19.0-Tutorials-coder branch 4 times, most recently from a2148ad to c501952 Compare February 19, 2026 12:08

AlessandroLupo reviewed Feb 19, 2026

View reviewed changes

coder-odoo added 2 commits February 19, 2026 15:27

[IMP] estate: Adding inheritance

f6ffdb2

[IMP] estate: Adding interaction with the Invoicing app

0338f3c

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 1bfcf89 to 0338f3c Compare February 19, 2026 14:27

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

[IMP] estate: Adding Kanban views

9dda914

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 0c0c697 to 9dda914 Compare February 20, 2026 10:19

[ADD] awesome_owl: Adding JS from ch. 1 to ch. 9

f7ee509

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 72594a6 to f7ee509 Compare February 20, 2026 10:56

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

[IMP] awesome_owl: Adding JS from Ch 10. to Ch. 13

626e597

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

		from odoo import models


		class EstatePropertyInherited(models.Model):

Comments

Conversation

coder-odoo commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants