Ongoing work on making a purely out-of-place version of ODL#1723
Draft
Emvlt wants to merge 17 commits intoodlgroup:masterfrom
Draft
Ongoing work on making a purely out-of-place version of ODL#1723Emvlt wants to merge 17 commits intoodlgroup:masterfrom
Emvlt wants to merge 17 commits intoodlgroup:masterfrom
Conversation
… a bug when calling the python built-in repr (None returned)
1) Fix the numpy version in install_requires to 2.3 (changes in 2.4 will break some of the functions). 2) Fix the torch version in the all to 2.9 (changes in 2.10 might break some of the functions).
…rted by the backend. 1) Changed the to which is shorter and does not loose inclarity. 2) Default use_in_place_ops as False in the TensorSpace 3) Began inserting checks on in_place support of operation where a method or function accepts an out argument. 4) Began changing tests to be skipped if the in-place is not supported.
…ation in Numpy 2.4 and modified tests accordingly
… used by the ProductSpaceElement if its space does not support it
It depends on the domain and the range supporting in-place operations
This involves skipping some tests (the __setitem__ for instance) and chaning the way some test elements are created (without using in-place updates).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To begin the work, I changed the default
support_in_place_opsproperty and disabled the__setitem__of theTensorSpaceElementas False and saw where things broke.I think that providing an
out_of_placeand anin_placeversion of each_calland setting the default argument out asNoneis a good way to make progress on this.At present, all the core test suite passes, but many improvements are still required.