Skip to content

chore: avoid reading proc environ if env prefix filter is emptry #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RonFed merged 1 commit into from
Mar 17, 2026
Merged

chore: avoid reading proc environ if env prefix filter is emptry #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions internal/proc/proc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ func getPodIDContainerNameFromReader(r io.Reader) (string, string, error) {
return "", "", ErrorNotK8sProcess
}

func isProcessRelevantToOdigos(pid int, prefix string) bool {
func isEnvPrefixExist(pid int, prefix string) bool {
if prefix == "" {
return true
}

path := procFile(pid, "environ")
fileContent, err := os.ReadFile(path)
if err != nil {
Expand Down Expand Up @@ -157,7 +161,7 @@ func AllRelevantProcesses(envPrefix string, exePathsToFilter map[string]struct{}
continue
}

if !isProcessRelevantToOdigos(int(pid), envPrefix) {
if !isEnvPrefixExist(int(pid), envPrefix) {
continue
}

Expand All @@ -173,6 +177,11 @@ func AllRelevantProcesses(envPrefix string, exePathsToFilter map[string]struct{}
}

func GetEnvironmentVars(pid int, keys map[string]struct{}) (map[string]string, error) {
// avoid opening the file if no keys are requested
if len(keys) == 0 {
return map[string]string{}, nil
}

path := procFile(pid, "environ")
fileContent, err := os.ReadFile(path)
if err != nil {
Expand Down
Loading