test(path): trailing slashes when appending#14279
Merged
Merged
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
6 tasks
shonfeder
approved these changes
Apr 21, 2026
Alizter
added a commit
that referenced
this pull request
May 14, 2026
Rather than using `Filename.concat` we use `/` as a directory separator on all platforms for paths that we construct. We already do this for local paths, so appending to external paths shouldn't be any different. This makes path behaviour homogeneous across platforms. Importantly on Windows something like: ``` C:\foo\bar + ./baz/zaz ``` used to be ``` C:\foo\bar\./baz/zaz ``` and is now ``` C:\foo\bar/baz/zaz ``` Notice that the prefix is untouched, since we don't control it. When scrubbing prefixes with `BUILD_PATH_PREFIX_MAP` this will mean that `$PREFIX/baz/zaz` will be the same on all platforms. That will be addressed in a later PR. We do however touch the prefix if it ends in a trailing directory separator. Before appending we make sure that this separator is stripped if it exists. - [x] changelog - [x] check docs and fixup - [x] update rocq tests - [x] update oxcaml tests - [x] update other tests - [x] #14279 Addresses parts of - #10176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More test cases documenting quirky path behaviour when working on #14278.