Pin @stacks/connect version and add wallet error handling#14
Open
warmidris wants to merge 2 commits intoobycode:mainfrom
Open
Pin @stacks/connect version and add wallet error handling#14warmidris wants to merge 2 commits intoobycode:mainfrom
warmidris wants to merge 2 commits intoobycode:mainfrom
Conversation
- Pin @stacks/connect to v8.2.5 for reproducible builds - Add VRS→RSV signature normalization (Leather returns VRS, Clarity expects RSV) - Add 3-tier signing fallback: @stacks/connect → direct provider → wallet-JSON format - Add cvToWalletJson() for older Leather versions that reject raw ClarityValue objects - Add wallet cancellation detection to avoid retrying after user explicitly cancels - Applied to both docs/app.js (docs UI) and server/ui/main.src.js (node console UI) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove over-engineered Leather compatibility layer (signature normalization, ClarityValue-to-JSON conversion, 3-tier fallback signing). Keep only the @stacks/connect@8.2.5 version pin and wallet cancellation error handling around the original direct request() calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
warmidris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stacks/connectto v8.2.5 in bothdocs/app.jsandserver/ui/main.src.js— the ESM CDN import was unpinned, which could break on upstream releasesisWalletCancellationErrorandnormalizeWalletPromptErrorrecognize user-cancelled prompts and surface a clean "Signature cancelled" message instead of cryptic errorsApplied to both
docs/app.js(docs site UI) andserver/ui/main.src.js(node console UI).Test plan
Generated with Claude Code