Skip to content

Conversation

@dragon-ai-agent
Copy link
Collaborator

Summary

This PR adds a new term UBERON:9900001 'sinus of lymph node' as requested in issue #3586.

Changes

  • Term ID: UBERON:9900001
  • Name: sinus of lymph node
  • Synonyms:
    • lymphatic sinus (EXACT)
    • lymph node sinus (EXACT)
  • Definition: A sinus located in a lymph node. Lymph nodes have subcapsular, cortical (trabecular) and medullary sinuses.
  • Logical definition:
    • intersection_of: UBERON:0000464 (anatomical space)
    • intersection_of: part_of UBERON:0000029 (lymph node)
  • Reference: Wikipedia:Lymph_node
  • Attribution: John Fostel (ORCID: 0000-0001-5858-4393)

Context

This term was requested by @jmfostel who works with pathologists at NIEHS. They have many pathology findings in the lymphatic sinus and need an anatomy term in UBERON to map these to. The term serves as a grouping class for the existing specific sinus terms:

  • UBERON:0005463 - subcapsular sinus of lymph node
  • UBERON:8410032 - trabecular sinus of lymph node
  • UBERON:8410074 - lymph node paracortical sinus
  • UBERON:0009744 - lymph node medullary sinus

Test plan

  • Term created with proper OBO format
  • Logical definition follows genus-differentia pattern
  • Attribution metadata included (dc-contributor, dcterms-date, term_tracker_item)
  • Synonyms added as requested
  • Reference to Wikipedia included

Closes #3586

🤖 Generated with Claude Code

Signed-off-by: @dragon-ai-agent

This commit adds a new term for 'sinus of lymph node' as requested in issue #3586.

The term represents a general grouping class for the various sinuses found in lymph
nodes, including subcapsular, cortical/trabecular, and medullary sinuses. It is defined
as an anatomical space that is part of the lymph node.

The term includes:
- Name: sinus of lymph node
- Synonyms: lymphatic sinus, lymph node sinus
- Logical definition: intersection_of anatomical space + part_of lymph node
- Reference: Wikipedia article on lymph nodes
- Attribution: John Fostel (ORCID: 0000-0001-5858-4393)

Closes #3586

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: @dragon-ai-agent
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

This PR modifies some logical definitions. See details below:

Number of classes with modified logical definitions: 1

sinus of lymph node

Added subclasses: 2

@dosumis
Copy link
Contributor

dosumis commented Nov 3, 2025

#gogoeditdiff

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-11-03/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2025-11-03/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

hepatic sinusoid of left lobe of liver http://purl.obolibrary.org/obo/UBERON_0009548

Removed

Added

hepatic sinusoid of right lobe of liver http://purl.obolibrary.org/obo/UBERON_0009549

Removed

Added

sinus of lymph node http://purl.obolibrary.org/obo/UBERON_9900001

Added

subcapsular sinus of lymph node http://purl.obolibrary.org/obo/UBERON_0005463

Removed

Added

trabecular sinus of lymph node http://purl.obolibrary.org/obo/UBERON_8410032

Removed

Added

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

hepatic sinusoid of left of lobe of liver http://purl.obolibrary.org/obo/UBERON_0009548

Removed

Added

hepatic sinusoid of right of lobe of liver http://purl.obolibrary.org/obo/UBERON_0009549

Removed

Added

sinus of lymph node http://purl.obolibrary.org/obo/UBERON_9900001

Added

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please add a new term, sinus of lymph node.

3 participants