Upgrade to Swift 2.2 and fix video input#1
Open
samuelbeek wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for writing this nice example project and the article that it came with, it has been really helpful.
The project didn't compile on Xcode 7.3 because the syntax wasn't Swift 2.2.
Next to that, the video input didn't work anymore, because it was using a private class, which had to be public.
I converted the syntax to Swift 2.2 so it will compile on Xcode 7.3 without any warnings or errors.
There are some force unwrapped optionals, they were in it before converting the project too, which I'd rather not have in there, but they're pretty harmless.
Let me know if you have any questions. Hope you merge this in, because everyone that is using the most recent Xcode has to do this by hand now.