Open
Conversation
obiwac
requested changes
Oct 15, 2024
Owner
obiwac
left a comment
obiwac
left a comment
There was a problem hiding this comment.
Thanks for the changes! Please try to integrate your code with the existing codebase rather than overwriting it however.
Author
|
The thing is I have been working on this from the episode 10 folder when you showed how to make chunks so I have not yet put toml if u can just create a separate branch and add it i will add the toml part and commit to it |
Author
|
It is integrated with the episode 10 codebase |
Author
|
it does not work when the save world option is there which was added in episode 11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have improved world generation by adding 2D perlin noise for hills and lakes with trees as well as 3D perlin noise for good looking spacious caves which have lava pools randomly generated ore veins of coal, iron and diamond depending upon the y level. This code right now generates only fixed number of chunks but the chunk generation can be used to produce infinite such chunks. I have also added jumping and sprinting mechanics and flying mode which can be toggled using F key. You also cant build below y = 0 level. There is also collision detection.