Refactor re-exports to use export…from syntax#35
Open
sonarqube-agent[bot] wants to merge 1 commit into
Open
Conversation
Fixed issues: - AZnd_k0G9LJ6Ep7Rin_0 for typescript:S7763 rule - AZnd_k0G9LJ6Ep7Rin_1 for typescript:S7763 rule - AZnd_k0G9LJ6Ep7Rin_2 for typescript:S7763 rule - AZnd_k0G9LJ6Ep7Rin_3 for typescript:S7763 rule - AZnd_k0G9LJ6Ep7Rin_4 for typescript:S7763 rule Generated by SonarQube Agent (task: baf47321-b2d5-44b0-8857-db3fd705ca05)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts 5 re-exported functions from manual import-and-export pattern to direct export…from statements in src/index.ts. This eliminates unnecessary intermediate imports and aligns with modern TypeScript best practices, resolving all SonarQube S7763 warnings in the module.
View Project in SonarCloud
Fixed Issues
typescript:S7763 - Use `export…from` to re-export `buildUnitTableRows`. • MINOR • View issue
Location:
src/index.ts:27Why is this an issue?
When re-exporting from a module, using separate import and export statements creates unnecessary verbosity and intermediate variables.
What changed
This hunk closes out the re-export of
removeSpecialCharacters,insertSpecialCharacters,sanitiseForDb, andsanitiseForTsvusingexport { ... } from './handleSpecialCharacters/index'syntax, and opens a newexport {block for the bulk uploads module. By converting these from the old pattern (where they were imported and then exported in a separate block) into directexport...fromstatements, this fixes the warnings aboutremoveSpecialCharactersandinsertSpecialCharactersbeing imported just to be re-exported. It also contributes to fixing the warnings forbuildTableRows,parseUpdates, andbuildUnitTableRowsby starting the newexport { ... } from './bulkUploads/index'block that is completed in hunk 4.typescript:S7763 - Use `export…from` to re-export `parseUpdates`. • MINOR • View issue
Location:
src/index.ts:26Why is this an issue?
When re-exporting from a module, using separate import and export statements creates unnecessary verbosity and intermediate variables.
What changed
This hunk closes out the re-export of
removeSpecialCharacters,insertSpecialCharacters,sanitiseForDb, andsanitiseForTsvusingexport { ... } from './handleSpecialCharacters/index'syntax, and opens a newexport {block for the bulk uploads module. By converting these from the old pattern (where they were imported and then exported in a separate block) into directexport...fromstatements, this fixes the warnings aboutremoveSpecialCharactersandinsertSpecialCharactersbeing imported just to be re-exported. It also contributes to fixing the warnings forbuildTableRows,parseUpdates, andbuildUnitTableRowsby starting the newexport { ... } from './bulkUploads/index'block that is completed in hunk 4.typescript:S7763 - Use `export…from` to re-export `removeSpecialCharacters`. • MINOR • View issue
Location:
src/index.ts:23Why is this an issue?
When re-exporting from a module, using separate import and export statements creates unnecessary verbosity and intermediate variables.
What changed
This hunk closes out the re-export of
removeSpecialCharacters,insertSpecialCharacters,sanitiseForDb, andsanitiseForTsvusingexport { ... } from './handleSpecialCharacters/index'syntax, and opens a newexport {block for the bulk uploads module. By converting these from the old pattern (where they were imported and then exported in a separate block) into directexport...fromstatements, this fixes the warnings aboutremoveSpecialCharactersandinsertSpecialCharactersbeing imported just to be re-exported. It also contributes to fixing the warnings forbuildTableRows,parseUpdates, andbuildUnitTableRowsby starting the newexport { ... } from './bulkUploads/index'block that is completed in hunk 4.typescript:S7763 - Use `export…from` to re-export `insertSpecialCharacters`. • MINOR • View issue
Location:
src/index.ts:24Why is this an issue?
When re-exporting from a module, using separate import and export statements creates unnecessary verbosity and intermediate variables.
What changed
This hunk closes out the re-export of
removeSpecialCharacters,insertSpecialCharacters,sanitiseForDb, andsanitiseForTsvusingexport { ... } from './handleSpecialCharacters/index'syntax, and opens a newexport {block for the bulk uploads module. By converting these from the old pattern (where they were imported and then exported in a separate block) into directexport...fromstatements, this fixes the warnings aboutremoveSpecialCharactersandinsertSpecialCharactersbeing imported just to be re-exported. It also contributes to fixing the warnings forbuildTableRows,parseUpdates, andbuildUnitTableRowsby starting the newexport { ... } from './bulkUploads/index'block that is completed in hunk 4.typescript:S7763 - Use `export…from` to re-export `buildTableRows`. • MINOR • View issue
Location:
src/index.ts:25Why is this an issue?
When re-exporting from a module, using separate import and export statements creates unnecessary verbosity and intermediate variables.
What changed
This hunk closes out the re-export of
removeSpecialCharacters,insertSpecialCharacters,sanitiseForDb, andsanitiseForTsvusingexport { ... } from './handleSpecialCharacters/index'syntax, and opens a newexport {block for the bulk uploads module. By converting these from the old pattern (where they were imported and then exported in a separate block) into directexport...fromstatements, this fixes the warnings aboutremoveSpecialCharactersandinsertSpecialCharactersbeing imported just to be re-exported. It also contributes to fixing the warnings forbuildTableRows,parseUpdates, andbuildUnitTableRowsby starting the newexport { ... } from './bulkUploads/index'block that is completed in hunk 4.SonarQube Remediation Agent uses AI. Check for mistakes.