feat: direct client payment without configuration#51
Open
shadyaziza wants to merge 4 commits intonyartech:mainfrom
Open
feat: direct client payment without configuration#51shadyaziza wants to merge 4 commits intonyartech:mainfrom
shadyaziza wants to merge 4 commits intonyartech:mainfrom
Conversation
a061e71 to
d352a50
Compare
pr-Mais
requested changes
May 19, 2023
| /// | ||
| /// [easyPay] does not provide a feedback on the status of payment, | ||
| /// since all config is moved to the server; it is the server | ||
| /// that should provide a separate api for the mobile application |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// that should provide a separate api for the mobile application | |
| /// that should provide a separate API for the mobile application |
| /// since all config is moved to the server; it is the server | ||
| /// that should provide a separate api for the mobile application | ||
| /// to request information about the status of a particular transaction. | ||
| /// |
Collaborator
There was a problem hiding this comment.
Could you add reference links from HyperPay's docs?
Collaborator
|
LGTM, sorry for taking a while to check this PR, well done 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new
easyPayapiWhich does not require any configuration from the client side. The possible workflow for this
checkoutIdfrom the serverCardInfoandBrandTypeentered by the user through a custom payment formeasyPaywith the needed data, the client should ask the server about the status of the payment