Skip to content

Conversation

@pajowu
Copy link
Contributor

@pajowu pajowu commented Sep 28, 2020

This PR fixes two bugs:

  1. Do not remove logfiles from the logfile map if their quota is updated. This lead to us removing all data from the sensor if the quota was changed at runtime.
  2. When appending a measurement, do not remove the logfile partition we just wrote to. This bug was triggered, when a storage quota < partition_size_bytes_default was set. The garbage collection marked the '0' partition to be deleted. After that the file was written, and then the marked partitions deleted, removing the just written data and leading to a corrupt storage.

If we remove it from the map, all existing data is overwritten on the next insert operation.
This bug was triggered, when a storage quota < partition_size_bytes_default was set.
The garbage collection marked the '0' partition to be deleted. After that the file
was written, and then the marked partitions deleted, removing the just written data
and leading to a corrupt storage.
@pajowu pajowu requested a review from asmuth September 28, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant