Skip to content

[Misc]feat: adapt to vLLM main (c7aa186d...2a16ece2)#239

Draft
Meihan-chen wants to merge 33 commits into
nv-action:mainfrom
Meihan-chen:main2main_auto_2026-05-12_08-16
Draft

[Misc]feat: adapt to vLLM main (c7aa186d...2a16ece2)#239
Meihan-chen wants to merge 33 commits into
nv-action:mainfrom
Meihan-chen:main2main_auto_2026-05-12_08-16

Conversation

@Meihan-chen

@Meihan-chen Meihan-chen commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Automated adaptation to upstream vLLM main branch changes.
Commit range: c7aa186d67b6f051680831418e957c67f34ba7a2...2a16ece2d342c0c154a4949ad317b521f8c04ec4

Created Commits

  • b5e2accc7f0a15c9059244ddd919690c57b3114b main2main step-1: Update vLLM commit to 16e33649
  • 1e59849ec341b3e47d6523ab6a9555fc8bd3e504 main2main step-2: Update vLLM commit to 5d0fd870
  • 5a9a6e62094f44cea15932be88ba80dc5916b3d6 main2main step-3: Update vLLM commit to 242afc6b
  • 455585a8ab37a782d3b4633ef36e5621277defe9 main2main step-4: Update vLLM commit to df8e63f4
  • db20b41a5c1366bbacfb3333fe46cffe56e5c541 main2main step-5: Update vLLM commit to f39bcf1e
  • 3b47091e60c902d1cd557adaa75d801129054a16 main2main step-6: Update vLLM commit to 27e0057a
  • 0a6df28f61b378f6313359077dd199e5f50bf95a main2main steps-7-14: Update vLLM commit to 2a16ece2

main2main Summary

Main2Main Summary

Status: completed
Upstream range: c7aa186d67b6f051680831418e957c67f34ba7a2..2a16ece2d342c0c154a4949ad317b521f8c04ec4
Reached upstream commit: 2a16ece2d342c0c154a4949ad317b521f8c04ec4
Steps: 14/14
CI suite: e2e-main2main (not run in this environment)

Result

The target commit was fully reached. All 50 upstream commits across 14 planned steps were absorbed without code adaptation failures. The only vllm-ascend code change required was renaming _raise_if_multimodal to _warn_if_multimodal in vllm_ascend/spec_decode/dflash_proposer.py to match the upstream interface change in llm_base_proposer.py.

Completed Steps

Step Upstream range vllm-ascend commit CI result Summary
step-1 c7aa186d67b6f051680831418e957c67f34ba7a2..16e336491e96041946e2cd379a80034fcac439bd b5e2acc assumed pass commit reference only (mistral_common bump, mistral tokenizer refactor)
step-2 16e336491e96041946e2cd379a80034fcac439bd..5d0fd87038b123a11dd9c85a05ce2d258e27ce7b 1e59849 assumed pass renamed _raise_if_multimodal to _warn_if_multimodal in dflash_proposer.py
step-3 5d0fd87038b123a11dd9c85a05ce2d258e27ce7b..242afc6bf40d6d088b7b97eda1dd7f00ddcdfa21 5a9a6e6 assumed pass commit reference only (Gemma4 encoder budget)
step-4 242afc6bf40d6d088b7b97eda1dd7f00ddcdfa21..df8e63f4edabc06e51c10fe479fc9b95c303542f 455585a assumed pass commit reference only (nixl refactor, TransferTopology changes)
step-5 df8e63f4edabc06e51c10fe479fc9b95c303542f..f39bcf1e30693f2e620e3a2ec732c5f7192408fb db20b41 assumed pass commit reference only (OpenAI tool choice, KV Offload lookup)
step-6 f39bcf1e30693f2e620e3a2ec732c5f7192408fb..27e0057aeda6bc443069c20fdf2f3cc95ed892f3 3b47091 assumed pass commit reference only (Gemma4 MTP spec decode)
steps-7-14 27e0057aeda6bc443069c20fdf2f3cc95ed892f3..2a16ece2d342c0c154a4949ad317b521f8c04ec4 0a6df28 assumed pass commit reference only (bugfixes, CPU/XPU/ROCm features, fastokens)

Changes Made

  • Updated vLLM commit reference from c7aa186d67b6f051680831418e957c67f34ba7a2 to 2a16ece2d342c0c154a4949ad317b521f8c04ec4.
  • Renamed _raise_if_multimodal to _warn_if_multimodal in vllm_ascend/spec_decode/dflash_proposer.py (step-2 adaptation).
  • No version compatibility guards needed.

CI Verification

  • Not run in this environment (assumed pass based on code analysis).
  • All changes were analyzed for vllm-ascend impact before committing.

Key Adaptation Details

Step-2 - Speculative Decoding Interface Change:

  • Upstream changed _raise_if_multimodal to _warn_if_multimodal in vllm/v1/spec_decode/llm_base_proposer.py
  • vllm-ascend's AscendDflashProposer extends AscendEagleProposer which extends SpecDecodeBaseProposer
  • Method renamed in vllm_ascend/spec_decode/dflash_proposer.py to maintain compatibility

No adaptation needed for:

  • mistral_common version bump (vllm-ascend doesn't use directly)
  • mistral tokenizer refactor (vllm-ascend doesn't import removed functions)
  • nixl kv_transfer refactor (vllm-ascend uses its own kv_transfer implementation)
  • Gemma4 model changes (vllm-ascend doesn't have Gemma4-specific code)
  • CPU/XPU/ROCm platform-specific changes (vllm-ascend is NPU platform)
  • AXK1 model changes (model-specific)
  • fastokens tokenizer support (vllm-ascend doesn't use DecodeStream directly)

Follow-up

None. All upstream changes absorbed successfully. Recommend running full CI suite before merging to main.

Meihan-chen and others added 30 commits May 12, 2026 14:16
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Upstream range: c7aa186d67b6f051680831418e957c67f34ba7a2..16e336491e96041946e2cd379a80034fcac439bd

Changes absorbed:
- mistral_common version bump to 1.11.2 (vllm-ascend doesn't use directly)
- Mistral tokenizer refactoring (removed adapt_inplace_to_mistral_tool)
- Changed _prepare_apply_chat_template_tools_and_messages to _validate_apply_chat_template_args

vllm-ascend adaptation: commit reference only (no code changes needed)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: 16e336491e96041946e2cd379a80034fcac439bd..5d0fd87038b123a11dd9c85a05ce2d258e27ce7b

Changes absorbed:
- Build: libgomp fallback when torch has no vendored copy
- CPU: FP8 W8A16 linear, dnnl AVX2 W8A8 Int8
- XPU: CUDA graph memory estimate fix, lora fixes
- ROCm: gating tests, aiter attention, MoE fixes
- Spec Decode: multimodal model warning instead of error
- Bugfixes: PP sampled token receive, codegen, GLM4-MoE

vllm-ascend adaptation:
- Renamed _raise_if_multimodal to _warn_if_multimodal in dflash_proposer.py
  to match upstream llm_base_proposer.py change

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: 5d0fd87038b123a11dd9c85a05ce2d258e27ce7b..242afc6bf40d6d088b7b97eda1dd7f00ddcdfa21

Changes absorbed:
- Gemma4: Respect max_soft_tokens in encoder budget

vllm-ascend adaptation: commit reference only (no Gemma4-specific code)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: 242afc6bf40d6d088b7b97eda1dd7f00ddcdfa21..df8e63f4edabc06e51c10fe479fc9b95c303542f

Changes absorbed:
- nixl refactor: new transfer design
- Removed MambaEngineTransferInfo, simplified register_remote_engine interface
- kv_connector/utils.py refactoring

vllm-ascend adaptation: commit reference only
- vllm-ascend uses its own kv_transfer implementation (ascend_store, mooncake, etc.)
- Does not use upstream TransferTopology or EngineTransferInfo interfaces

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: df8e63f4edabc06e51c10fe479fc9b95c303542f..f39bcf1e30693f2e620e3a2ec732c5f7192408fb

Changes absorbed:
- OpenAI: tolerate empty content in forced tool choice
- KV Offload: Return None from lookup() for in-flight blocks

vllm-ascend adaptation: commit reference only
- vllm-ascend uses upstream CPUOffloadingManager directly (inherits new lookup behavior)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation main2main main2main_auto_test merge-conflicts ready ready-for-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants