fix(search): normalize non-array search responses to prevent results.map crash#1
Open
fkysly wants to merge 1 commit intonumman-ali:mainfrom
Open
fix(search): normalize non-array search responses to prevent results.map crash#1fkysly wants to merge 1 commit intonumman-ali:mainfrom
fkysly wants to merge 1 commit intonumman-ali:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
zai-cli searchwhen the MCP search response is not an array.Error observed:
What changed
In
packages/zai-cli/src/commands/search.ts:normalizeSearchResults(input)helper to accept multiple response shapes:[]{ results: [] }{ data: [] }{ items: [] }resultsis always an arrayrank,title,url,summary,source,date)Why
Some queries (notably some non-English queries) can return a payload shape that differs from the expected array, which previously caused the command to crash. This patch makes parsing resilient and degrades gracefully (empty list instead of process failure).
Validation
npm run buildpasses