feat: Finalize URL format with attempted future-proofing #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Huh, just saw that there are test failures here, I was not expecting any. I am on a plane but will investigate and fix tonight. |
Collaborator
Author
|
OK, sorry, the conference took its toll on my ability to get to this. But all appears well now. If nobody has a chance to look at this by the time I am next able to work on it, I am going to go ahead and merge it so that I can work on the last remaining issue #581 before the alpha release. Thanks for any attention you can give this! |
Collaborator
Author
|
OK I looked this over again and I am satisfied so in the interest of a last-ditch effort for "alpha by Paris!" I am going to squash and merge it myself so that I can get on with working on #581. Hope we don't live to regret this ;-) |
This was referenced Jan 10, 2026
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
Adds fields for the git revision and frontscope version number to all URLs, including the featured specimens. Institutes a new convention that if the the URL format changes, the frontscope version number will have to be incremented, and translations (or when not possible, clear diagnostic messages) will have to be provided for backwards-compatibility of prior URLs.
Also renames
FactorFencetoFactorStacksper 439.Resolves #263.
Resolves #439.
Resolves #440.
@katestange and @Vectornaut let me know if you will be able to review this by Jan 5, or if not, if you are comfortable with my merging this without independent review. Since there is no new functionality, just fields added to URLs for future reference, I am personally comfortable merging it myself. But if you prefer that not happen, I am OK with waiting.