Skip to content

Conversation

@liammulh
Copy link
Member

@liammulh liammulh commented May 3, 2023

Closes #73.

We now know the exact steps to get a working instance of backscope on a fresh Ubuntu, so I have updated the README with those steps.

message) then your distribution is lacking these header files. You likely
will need to install the "Python development" package for your operating
system (the details of doing so are beyond the scope of these instructions).
message) then your distribution is lacking these header files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understand; this phrasing has been removed because it went from "beyond the scope" to being included below, right?

public | user | table | <username for psql>
public | user_id_seq | sequence | <username for psql>
db=# \q
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the above commands or output or both?

@gwhitney
Copy link
Collaborator

My two cents: The install instructions have now become too long/detailed/low-level for a README. My recommendation is to provide a high-level setup overview in the README (similar to what was there before, but even more of an outline) and move the detailed instructions from this into something like doc/install-Ubuntu.md. (Maybe while you are at it, rename the only md file that uses an underscore as a separator to use a dash instead, so they are consistent.) I'm not going to insist on such changes, but if these suggestions seem reasonable, please modify the PR (in addition of course to responding to Kate's review).

liammulh added a commit that referenced this pull request May 24, 2023
This PR does the following:

- adds a code formatter (Black)
- adds a linter (ruff)
- adds tests (Pytest)
- documents code by adding Python docstring comments to functions and
  methods
- attempts to address #69
- attempts to address some of the feedback in
  #74

There are some minor changes that aren't worth delving into in the
commit message. The API has changed somewhat, so if we were using
Semantic Versioning, this would be a breaking change / major version
upgrade.

I will go into more detail in the pull request description on GitHub.
@liammulh
Copy link
Member Author

#76 supersedes this PR.

@liammulh liammulh closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update README with comprehensive install steps

3 participants