Bug fix: filters could be None#416
Open
haukekoehn wants to merge 2 commits into
Open
Conversation
When doing an analysis, one should be able to leave the filters unspecified, so that in the end just the filters from the data are taken. This happens later, when filters_to_analyze is determined. But before that, it tries to find a detection_limit depending on filter, which will fail if filter is not specified. This edit fixes this, although I am not sure if it's in the most elegant way imaginable.
Now the function ignores lines starting with a #, so that the header line is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing an analysis, one should be able to leave the filters unspecified, so that in the end just the filters from the data are taken. This happens later, when filters_to_analyze is determined. But before that, it tries to find a detection_limit depending on filter, which will fail if filter is not specified.
This edit fixes this, although I am not sure if it's in the most elegant way imaginable.