Add support to return a span element without a code wrap#46
Open
resaldiv wants to merge 3 commits intonteract:masterfrom
Open
Add support to return a span element without a code wrap#46resaldiv wants to merge 3 commits intonteract:masterfrom
resaldiv wants to merge 3 commits intonteract:masterfrom
Conversation
|
Is there a reason to support this (eg, what's the use case)? Semantically, Also, the pattern I've seen for this stuff out "in the wild" is using an |
Author
|
Yes, I just opened this issue that explains in a better way the reason to support this and updated the description of this PR. Thanks for the suggestion! I'm going to change the prop, to follow the pattern you mentioned. |
twavv
reviewed
Oct 29, 2020
| ansiToJSON(children ?? "", useClasses ?? false).map( | ||
| elementType, | ||
| elementProps, | ||
| ansiToJSON(children ?? "", useClasses ?? false, anser ?? new Anser()).map( |
There was a problem hiding this comment.
This is a big no-no in React because it means that your renders are no longer pure (the component ends up mutating the internal state of the Anser instance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it seems that React can't handle the memory pressure when a large output of text is being rendered. This PR is part of the solution for this issue and adds a new prop that indicates whether Ansi should return a span element without a code wrap.