Hide menu#1
Open
tecnogram888 wants to merge 4 commits into
Open
Conversation
allows somebody tabbing into a prosemirror to see/heac a descriptive label for the contenteditable area set by prosemirror.
tecnogram888
force-pushed
the
hideMenu
branch
from
78b7c73 to
bb9b4ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current logic only changes opacity to 0, which doesn't prevent users from clicking the invisible menu. This makes the menu unclickable, and it works because the 'show' logic re-adds new dom elements to the page, trashing the ones we hid with display: 'none'