-
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: local directory interactive mode #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b4a4629
feat: local directory interactive mode
nrjdalal 524ffbc
fix: edge cases for local interactive mode
nrjdalal 2a0fe7f
fix: use git ls-files to respect .gitignore for local interactive
nrjdalal 5e59e36
fix: error on missing source with explicit target, preserve symlinks …
nrjdalal bb103bd
fix: remove existing dest before symlink creation, don't count failures
nrjdalal 1852d29
fix: warn on symlink copy failure instead of swallowing silently
nrjdalal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Score: 4/10 for correctness in this area. This fallback silently rewrites a nonexistent first positional into
target = url; url = ".". With two args, a typo likegitpick -i mising-dir outstops meaning "source + target" and instead browses the current working directory, writes intomising-dir, and ignoresout. This should only be allowed for the single-positional shorthand; when both source and target are present, a missing source should error.