Open
Conversation
EAN13 calculation corrected
nrivard
requested changes
Jan 15, 2024
|
|
||
| return String(calculatedChecksum) == value.last.map({ String($0) }) | ||
| let digits = value.compactMap { Int(String($0)) } | ||
| let lastDigit = digits.last! |
Owner
There was a problem hiding this comment.
This seems inherently unsafe if after the compactMap there are zero elements in digits. Previous code was written a long time ago I should have probably made it safer long ago 😂 Haven't looked at this code in awhile so maybe there are other verification steps that make sure it's the proper number of digits but you may want to check that value.count == digits.count
Author
There was a problem hiding this comment.
@nrivard yes, I've seen it, but on line 16 you checked digits, so it is actually fine:
Owner
|
Also @hrabkin thank you for contributing 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EAN13 calculation corrected - was failing on this one "5903779001320"