I499 edit questions

app/assets/stylesheets/_create-question-form.scss

@@ -3,6 +3,16 @@
 @import '../../../node_modules/bootstrap/scss/mixins';
 
 .create-question-form {
+  .question-form-main {
+    max-width: 70%;
+    min-width: 0;
+  }
+
+  .question-form-sidebar {
+    min-width: 250px;
+    width: 30%;
+  }
+
   @include media-breakpoint-down(md) {
     .question-body {
       margin-top: .5rem !important;
@@ -14,5 +24,11 @@
     .tag-section {
       margin: 0 !important;
     }
+    .question-form-main {
+      max-width: 100%;
+    }
+    .question-form-sidebar {
+      width: 100%;
+    }
   }
 }

app/controllers/api/questions_controller.rb

@@ -43,6 +43,50 @@ def create
     render json: { errors: [e.message] }, status: :unprocessable_entity
   end
 
+  def update
+    question = Question.find_by(id: params[:id])
+
+    if question.nil?
+      render json: { errors: ['Question not found.'] }, status: :not_found
+      return
+    end
+
+    return unless validate_permissions(question)
+
+    processed_params = process_question_params(question_params)
+    update_question_in_transaction(question, processed_params)
+  rescue ArgumentError => e
+    render json: { errors: [e.message] }, status: :unprocessable_entity
+  end
+
+  # rubocop:disable Metrics/MethodLength
+  def update_question_in_transaction(question, processed_params)
+    # Wrap all updates in a transaction for atomicity
+    Question.transaction do
+      # Clear existing associations before updating
+      question.keywords.clear
+      question.subjects.clear
+
+      # Update question attributes
+      question.assign_attributes(processed_params.except(:keywords, :subjects, :images, :alt_text, :deleted_image_ids, :existing_images))
+      question.level = nil if question.level.blank?
+
+      # Handle associations
+      handle_question_associations(question)
+
+      unless question.save
+        render json: { errors: question.errors.full_messages }, status: :unprocessable_entity
+        raise ActiveRecord::Rollback
+      end
+
+      handle_image_changes!
+    end
+
+    # Only render success if we got here without rolling back
+    render json: { message: 'Question updated successfully!', id: question.id }, status: :ok if question.persisted? && question.errors.empty?
+  end
+  # rubocop:enable Metrics/MethodLength
+
   def destroy
     question = Question.find_by(id: params[:id])
 
@@ -68,7 +112,7 @@ def handle_delete_action(success, success_key, failure_key)
 
   def validate_permissions(question)
     unless question.user_id == current_user.id || current_user.admin?
-      render json: { errors: ['You do not have permission to delete this question.'] }, status: :forbidden
+      render json: { errors: ['You do not have permission to perform this action on this question.'] }, status: :forbidden
       return false
     end
     true
@@ -97,6 +141,27 @@ def handle_question_associations(question)
     handle_subjects(question)
   end
 
+  def handle_image_changes!
+    deleted_image_ids = question_params[:deleted_image_ids]
+    existing_images = question_params[:existing_images]&.map(&:to_h)
+
+    return if deleted_image_ids.blank? && existing_images.blank?
+
+    # Batch delete images to avoid N+1 queries
+    Image.where(id: deleted_image_ids).destroy_all if deleted_image_ids.present?
+
+    # Batch fetch and update existing images to avoid N+1 queries
+    return if existing_images.blank?
+
+    image_ids = existing_images.pluck('id').compact
+    images_by_id = Image.where(id: image_ids).index_by(&:id)
+
+    existing_images.each do |existing_image|
+      image = images_by_id[existing_image['id'].to_i]
+      image&.update(alt_text: existing_image['alt_text'])
+    end
+  end
+
   ##
   # Processes and normalizes the question parameters.
   #
@@ -593,7 +658,9 @@ def question_params
       images: [],
       keywords: [],
       subjects: [],
-      alt_text: []
+      alt_text: [],
+      deleted_image_ids: [],
+      existing_images: [:id, :alt_text]
     )
   end
 end