Make digest_sha1 work for Valkyrie as well as Wings/Fedora#409
Merged
Conversation
Valkyrie uses the MD5 algorithm for `digest_ssim` which doesn't have the beginning `sha1:` - this reformulation works for either algorithm
maxkadel
added
bug
ShanaLMoore
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
Valkyrie uses the MD5 algorithm for
digest_ssimwhich doesn't have the beginningsha1:- this reformulation works for either algorithmExpected Behavior Before Changes
For applications using Valkyrie, iiif manifests using an
EXTERNAL_IIIF_URLdid not include links to the info.json, becausedigest_sha1raises an error for digests without algorithm prefixes - the manifest could not create the correct link.Expected Behavior After Changes
Applications using Valkyrie with an
EXTERNAL_IIIF_URLcan create valid iiif manifests using Valkyrie-generated digests.Notes
This also adds the option to add a prefix to the
external_latest_file_id- this allows for differentiating S3 paths by environment.