Fix circular autoload in decorate_form_with_adapter_logic #407
Merged
Conversation
…flexible mode is enabled
In Hyrax flexible metadata mode, `Hyrax::FormFields(:child_works_from_pdf_splitting)`
is a no-op, but the unconditional `"#{work_type}Form".constantize` call was triggering
a circular autoload error when a model was loaded before its form. Guard the entire
method with an early return when `Hyrax.config.flexible?` is true.
This removes the need for the monkey-patch that knapsack apps (e.g. hykuup_knapsack)
had to apply via a local initializer (refs notch8/hykuup_knapsack#630).
laritakr
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Hyrax flexible metadata mode,
Hyrax::FormFields(:child_works_from_pdf_splitting)is a no-op, but the unconditional"#{work_type}Form".constantizecall was triggering a circular autoload error when a model was loaded before its form. Guard the entire method with an early return whenHyrax.config.flexible?is true.This removes the need for the monkey-patch that knapsack apps (e.g. hykuup_knapsack) had to apply via a local initializer (refs notch8/hykuup_knapsack#630).
Issue: