Skip to content

Remove actions that either never worked or no longer work#1044

Closed
maxkadel wants to merge 1 commit into
mainfrom
remove_github_actions
Closed

Remove actions that either never worked or no longer work#1044
maxkadel wants to merge 1 commit into
mainfrom
remove_github_actions

Conversation

@maxkadel

Copy link
Copy Markdown
Member

brakeman-audit and bundler-audit have never been run on this repo. Rather than trying to update and fix them under https://github.com/notch8/dev-ops/issues/1324, I think we should remove them until we can implement them fully on their own.

If we decide we want these, we can re-add them one at a time and make sure they're functioning.

- If we decide we want these, we can re-add them one at a time and make sure they're functioning
@github-actions

Copy link
Copy Markdown

Test Results

      4 files  ±0        4 suites  ±0   41s ⏱️ +4s
362 935 tests ±0  362 894 ✅ ±0  41 💤 ±0  0 ❌ ±0 
    939 runs  ±0      898 ✅ ±0  41 💤 ±0  0 ❌ ±0 

Results for commit 617de0e. ± Comparison against base commit 41250a1.

@aprilrieger

aprilrieger commented Jun 12, 2026

Copy link
Copy Markdown
Member

I was able to get these working with the new actions with the include of --no-deps for the knapsack projects.

Actions pr: notch8/actions#115
Adventist actions update PR: #1045

Successfully failing on adventist:

Successfully failing on the non-knapsack example utk-hyku with the update:

@maxkadel

Copy link
Copy Markdown
Member Author

Great, thanks April, I'll go ahead and close this PR.

@maxkadel maxkadel closed this Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants