Skip to content

Update gh actions#1039

Merged
maxkadel merged 7 commits into
mainfrom
update_gh_actions
Jun 12, 2026
Merged

Update gh actions#1039
maxkadel merged 7 commits into
mainfrom
update_gh_actions

Conversation

@maxkadel

@maxkadel maxkadel commented Jun 8, 2026

Copy link
Copy Markdown
Member

Upgrade to newest version of Github Actions

  • Use web image for docker-compose
  • Build solr image in Dockerfile
  • Symlink whole solr directory from hyrax-webapp

Connected to https://github.com/notch8/dev-ops/issues/1324

maxkadel added 4 commits June 8, 2026 13:56
@maxkadel
Update to use new github actions
33c44b5 
- Use web image for docker-compose
- Build solr image in Dockerfile
- Symlink whole solr directory from hyrax-webapp
@maxkadel
Update more actions
3a20973
@maxkadel
Fix build step
78dc1cf
@maxkadel
Update production docker to use correct image
d0949fc
@github-actions

github-actions Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

      4 files        4 suites   42s ⏱️
362 935 tests 362 894 ✅ 41 💤 0 ❌
    939 runs      898 ✅ 41 💤 0 ❌

Results for commit d98fe2d.

♻️ This comment has been updated with latest results.

aprilrieger
aprilrieger reviewed Jun 10, 2026
View reviewed changes
Comment thread .github/workflows/build-test-lint.yaml
with:
webTarget: hyku-web
workerTarget: hyku-worker
components: '["web","worker"]'

@aprilrieger aprilrieger Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we will also need to build the solr image to deploy as well.

@maxkadel maxkadel Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand why?

It looks like it uses the upstream samvera/hyku solr image?

@aprilrieger aprilrieger Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding internal comms: https://notch8.slack.com/archives/C088B7J0WL8/p1781191645619049?thread_ts=1781166268.622829&cid=C088B7J0WL8

Thank you for giving me an opportunity to review. Since this one uses the production docker-compose file you are absolutely correct in your comment for the solr image. Approving.

aprilrieger
aprilrieger approved these changes Jun 11, 2026
View reviewed changes

@aprilrieger aprilrieger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max!

@maxkadel maxkadel merged commit 41250a1 into main Jun 12, 2026
12 checks passed
@maxkadel maxkadel deleted the update_gh_actions branch June 12, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aprilrieger aprilrieger aprilrieger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxkadel @aprilrieger