fix: linenos highlighting for Zola 0.22+ (#168)#171
Open
not-matthias wants to merge 4 commits into
Open
Conversation
Update nixpkgs flake input, fix removed nodePackages.prettier -> prettier, and bump Dockerfile.test from Zola 0.19.2 to 0.22.1.
Playwright Tests failed!Download the test report from the workflow artifacts. |
Playwright Tests passed!All visual regression tests passed successfully! |
not-matthias
force-pushed
the
feat/linenos-highlighting
branch
from
a87fb07 to
50c539e
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
- Add user-select: none and proper spacing to .giallo-ln - Strip .giallo-ln elements before copying in codeblock.js - Add full-width highlight styling for .z-hl lines - Remove dead table-based linenos code (replaced by giallo in Zola 0.22) - Darken light theme highlight color for better visibility
not-matthias
force-pushed
the
feat/linenos-highlighting
branch
from
50c539e to
c9a2fde
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
Add linenos-test page as both user-facing reference and test fixture, showing source and rendered output for each feature: line numbers, single/multi/range highlights, linenostart, and hide_lines.
- Add -webkit-user-select prefix for Safari support - Skip clipboard test on WebKit (no clipboard permissions API) - Use webkitUserSelect fallback in user-select test assertion
not-matthias
force-pushed
the
feat/linenos-highlighting
branch
from
c9a2fde to
7029e31
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168 — line numbers in code blocks were selectable and included when copying.
user-select: noneand proper spacing to.giallo-lnline numbers.giallo-lnelements before copying incodeblock.js.z-hlhighlighted lines/posts/linenos-test/) showing all highlighting featuresTest plan