Open
Conversation
pablof7z
reviewed
Feb 24, 2026
Collaborator
pablof7z
left a comment
There was a problem hiding this comment.
Code Review: Good concept, has merge conflicts
The namespace improvement is sensible — changing ndk:outbox-pool to ndk:pool:outbox and lowercasing pool names creates a more consistent debug namespace hierarchy.
However:
- Merge conflicts — This PR conflicts with the current master branch and needs a rebase.
- Import reformatting — The cosmetic changes to import spacing add noise. The meaningful changes are just ~4 lines.
@digitalbase Could you rebase this on master and remove the import formatting changes? The actual namespace fix is clean and we'd be happy to merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: