Skip to content

Minor improvement to debug namespace#361

Open
digitalbase wants to merge 2 commits intomasterfrom
feature/pool-debug-namespace
Open

Minor improvement to debug namespace#361
digitalbase wants to merge 2 commits intomasterfrom
feature/pool-debug-namespace

Conversation

@digitalbase
Copy link
Copy Markdown
Collaborator

Before:

tsx debug.test.ts                                     
  ndk:pool:Main Connecting to 0 relays... +0ms
  ndk:outbox-pool Connecting to 2 relays... +0ms

After:

tsx debug.test.ts                                     
  ndk:pool:main Connecting to 0 relays... +0ms
  ndk:pool:outbox Connecting to 2 relays... +0ms

@digitalbase digitalbase requested a review from pablof7z December 12, 2025 12:53
Copy link
Copy Markdown
Collaborator

@pablof7z pablof7z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Good concept, has merge conflicts

The namespace improvement is sensible — changing ndk:outbox-pool to ndk:pool:outbox and lowercasing pool names creates a more consistent debug namespace hierarchy.

However:

  1. Merge conflicts — This PR conflicts with the current master branch and needs a rebase.
  2. Import reformatting — The cosmetic changes to import spacing add noise. The meaningful changes are just ~4 lines.

@digitalbase Could you rebase this on master and remove the import formatting changes? The actual namespace fix is clean and we'd be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants