Clarify ignore-files help string#1076
Open
jimrollenhagen wants to merge 1 commit intonose-devs:masterfrom
Open
Clarify ignore-files help string#1076jimrollenhagen wants to merge 1 commit intonose-devs:masterfrom
jimrollenhagen wants to merge 1 commit intonose-devs:masterfrom
Conversation
It isn't immediately clear that this option only checks the basename of the file, rather than the entire path - make it a bit clearer in the help message so that people don't end up digging through the code to find this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It isn't immediately clear that this option only checks the basename of
the file, rather than the entire path - make it a bit clearer in the
help message so that people don't end up digging through the code to
find this out.