Make coverage plugin compatible with Coverage.py 4.1#1004
Make coverage plugin compatible with Coverage.py 4.1#1004mitya57 wants to merge 1 commit intonose-devs:masterfrom
Conversation
According to the Coverage.py 4.1 changelog: - The `Coverage.report` function had two parameters with non-None defaults, which have been changed. `show_missing` used to default to True, but now defaults to None. If you had been calling `Coverage.report` without specifying `show_missing`, you'll need to explicitly set it to True to keep the same behavior. Without that option, four tests in nose fail: - test_coverage_plugin.TestCoverageMinPercentagePlugin - test_coverage_plugin.TestCoverageMinPercentageSinglePackagePlugin - test_coverage_plugin.TestCoverageMinPercentageSinglePackageWithBranchesPlugin - test_coverage_plugin.TestCoveragePlugin
|
Needed to apply this to the Fedora python-nose package to get it to pass tests with converage 4.2, so +1 here. |
|
Nose is unmaintained. Unless someone else takes over maintainership, it's not going to happen. Sorry. |
|
Is In case of the latter, then a note could be added to the README of |
|
There is a note on the main page of the docs: http://nose.readthedocs.io/en/latest/ Yes, I think you should be looking at Nose 2. It's not compatible with Nose 1.x though. Make sure to read the caveats. Also, the README is auto-generated. If you put together a proper patch to document that fact, then I'll merge it. |
|
Thanks for the information. I'll try to create a patch for the code that generates the README. |
According to the Coverage.py 4.1 changelog:
Coverage.reportfunction had two parameters with non-None defaults,which have been changed.
show_missingused to default to True, but nowdefaults to None. If you had been calling
Coverage.reportwithoutspecifying
show_missing, you'll need to explicitly set it to True to keepthe same behavior.
Without that option, four tests in nose fail:
The example of the failure can be seen in https://bugs.debian.org/828224.