Fix curl dep on gnutls#34
Open
Grissess wants to merge 1 commit into
Open
Conversation
gnutls is a slightly more obscure library than openssl; this isn't a problem in and of itself, but the build for portable AppImage files still ships with a dependency on this library--and it isn't integrated into the AppImage squashfs. Linking against the (more popular) OpenSSL build of libcurl ought to improve compatibility on various Linux distributions.
|
Context for the bug that this pull request fixes is found in this comment and by extension this upstream discussion of it . I second merging this fix as the upstream discussion of the actual bug is from 2022 and not likely to be fixed any time soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33.
The changed dep is automatically picked up by pkg-config, so no other changes are needed.
Observe a correct build here; ignore the overall workflow's failure, that's just because I don't (and shouldn't) have permission to upload the artifacts to your repositories :)