Cleanup a whole pile of build warnings#31
Open
j-mutter wants to merge 1 commit into
Open
Conversation
eee2f6f to
b8d4dab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when building BK, there are 755 warnings:
This is super noisy, and obscures potential problems, so I've gone ahead and cleaned up pretty much all of them but 2:
The vast majority were missing
overrides on methods, and the rest were a bit of a mixed bag of initializer/field ordering, unused variables, unhandled values inswitchstatements, etc.For the switch statements specifically, I opted to add all the missing values instead of just a
defaultas a bit of documentation and to help searching in the future, and I tried to group them in a somewhat logical manner.There were a couple places where accessors were being called and completely unused, so maybe those were just mistakes and the intent was to actually set a value? I left comments around those ones - they are mostly
isControllableFeedbackOnlycalls in some UI elements that should maybe besetControllableFeedbackOnly?The two that I left are as follows:
A warning about the version of
libServusthat is bundled in the app. It was built against MacOS 10.15, and I am currently linking against 10.13. This is also up from 10.10 which was causing a slew of similar warnings with other packages. 10.13 is almost 10 years old at this point, so I figured increasing that was probably fine, but I wasn't sure about jumping all the way to 10.15, even though things might not work properly on older versions anyway.The unused function
getAppinBlinderKitten/Modules/juce_organicui/app/OrganicApplication.h. Obviously it's unused and can be removed, but it seemed like maybe something that might be needed later without having to go find/recreate it again.