WIP: Logical vs dmx channels#28
Draft
j-mutter wants to merge 10 commits into
Draft
Conversation
2ccfc66 to
d16200b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very much still a work in progress, but wanted to get some more eyes on it before going much further.
This PR implements a new hierarchical channel structure that more closely follows the GDTF spec, ie, where logical channels are defined below physical DMX channels.
Also enables split-channel functionality:
SubFixtureChannel(and thusFixtureTypeChannel) are still the main interface for writing attribute values, but they now act as logical channels and the DMX resolution/output happens one step further down the stack.Key Changes
Fixture definitions:
FixtureTypeDMXChannelrepresenting raw fixture DMX channelsFixtureTypeChannelobjects are nested underFixtureTypeDMXChannels as logical channels, and can be assigned to specific ranges within the DMXChannel. Split channels work as expected, but currently only for 8bit channelsFixture instances:
SubFixtureChannels now register with a parentFixtureDMXChanneland no longer directly write to patched outputsFixtureDMXChannelresolves which logical channel should drive the output, and maps the logical value to the raw DMX value and writes it to the patchChannel Resolution:
TODOs
DMX Channel > Channels > Channelis a bit awkward. Maybe the logical channels become "Attribute"s or "Function"s like in GDTF)highlightshould technically live on theDMXChannelnow, currently if you set ahighlight = 1.0on a split channel, it will get mapped within the range and won't use 255 for example. This is solvable, I just didn't get to it yet.