security: enforce GlasswallyAgent partial-line buffer cap (STRIDE D-6)#37
Merged
Conversation
STRIDE D-6 declared the GlasswallyAgent line buffer "capped", but no cap existed. Glasswally is a separate privileged process; a write that never emits a newline (truncated mid-entry, or a compromised Glasswally) grew lineBuffer by up to MAX_BYTES_PER_TICK every tick, unbounded, exhausting the EverythingOS process memory — a fail-open DoS on a security control. Add MAX_LINE_BUFFER (1 MB): a partial line exceeding it can never be a valid record (records cap at 64 KB), so it is discarded as unrecoverable and bytes are skipped until the next newline, resuming cleanly at the following record. Complete lines preceding the oversized fragment are still delivered. The discard is audit-logged. Adds a regression suite proving the attack path is bounded and recovers. https://claude.ai/code/session_01ArAvRMiZgCwF5oNj3r94Ap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STRIDE D-6 declared the GlasswallyAgent line buffer "capped", but no cap existed. Glasswally is a separate privileged process; a write that never emits a newline (truncated mid-entry, or a compromised Glasswally) grew lineBuffer by up to MAX_BYTES_PER_TICK every tick, unbounded, exhausting the EverythingOS process memory — a fail-open DoS on a security control.
Add MAX_LINE_BUFFER (1 MB): a partial line exceeding it can never be a valid record (records cap at 64 KB), so it is discarded as unrecoverable and bytes are skipped until the next newline, resuming cleanly at the following record. Complete lines preceding the oversized fragment are still delivered. The discard is audit-logged.
Adds a regression suite proving the attack path is bounded and recovers.