Skip to content

fix Application.addMiddleware#144

Open
artem-burlakov-ext-orion wants to merge 1 commit into
nodosjs:masterfrom
artem-burlakov-ext-orion:fix_addmiddleware_branch
Open

fix Application.addMiddleware#144
artem-burlakov-ext-orion wants to merge 1 commit into
nodosjs:masterfrom
artem-burlakov-ext-orion:fix_addmiddleware_branch

Conversation

@artem-burlakov-ext-orion

Copy link
Copy Markdown

before:

addMiddleware(filepath) {
    const filename = path.basename(filepath);
    const middlewareName = filename.replace(path.extname(filename), '');
    log('addMiddleware', middlewareName, filepath);
    // FIXME: check uniqueness
    this.middlewares[middlewareName] = filepath;
  }

after:

addMiddleware(filepath) {
    const filename = path.basename(filepath);
    const middlewareName = filename.replace(path.extname(filename), '');
    log('addMiddleware', middlewareName, filepath);
    if (has(this.middlewares, middlewareName)) {
      throw new Error(`Middleware '${middlewareName}' already exists`);
    }
    this.middlewares[middlewareName] = filepath;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant