Skip to content

Add openEuler OS support for RPM-based distributions#1929

Open
JunchengDwain wants to merge 1 commit intonodesource:masterfrom
JunchengDwain:master
Open

Add openEuler OS support for RPM-based distributions#1929
JunchengDwain wants to merge 1 commit intonodesource:masterfrom
JunchengDwain:master

Conversation

@JunchengDwain
Copy link
Copy Markdown

@JunchengDwain JunchengDwain commented Mar 26, 2026

  • Added /etc/openEuler-release file check in RPM detection logic
  • Modified all RPM setup scripts (setup_*.x) and base_script.sh
  • Added openEuler to GitHub Actions CI workflow:
    • rpm job: openeuler/openeuler:22.03-lts-sp4, openeuler/openeuler:24.03-lts-sp3

Summary by CodeRabbit

  • New Features

    • Added support for OpenEuler distributions in installation and setup scripts.
  • Chores

    • Expanded CI testing coverage to include OpenEuler LTS variants.

- Added /etc/openEuler-release file check in RPM detection logic
- Modified all RPM setup scripts (setup_*.x) and base_script.sh
- Added openEuler to GitHub Actions CI workflow (rpm job only):
  - openeuler/openeuler:22.03-lts-sp4
  - openeuler/openeuler:24.03-lts-sp3
- Note: openEuler has no minimal variant, so not added to rpm-minimal job
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a5ba2aec-b945-4744-a733-feb0e5619014

📥 Commits

Reviewing files that changed from the base of the PR and between c6e581b and c6753d4.

📒 Files selected for processing (12)
  • .github/workflows/ci.yaml
  • scripts/rpm/script_generator/base_script.sh
  • scripts/rpm/setup_16.x
  • scripts/rpm/setup_18.x
  • scripts/rpm/setup_20.x
  • scripts/rpm/setup_21.x
  • scripts/rpm/setup_22.x
  • scripts/rpm/setup_23.x
  • scripts/rpm/setup_24.x
  • scripts/rpm/setup_25.x
  • scripts/rpm/setup_current.x
  • scripts/rpm/setup_lts.x

Walkthrough

This pull request extends OpenEuler OS support across Node.js distribution installation scripts. Two OpenEuler container images were added to CI testing workflows, and RPM system detection logic was updated across all setup scripts to recognize OpenEuler systems as valid RPM-based environments alongside existing Red Hat and Amazon Linux checks.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml
Added OpenEuler 22.03-lts-sp4 and 24.03-lts-sp3 container images to the rpm job test matrix.
RPM System Detection
scripts/rpm/script_generator/base_script.sh, scripts/rpm/setup_16.x, scripts/rpm/setup_18.x, scripts/rpm/setup_20.x, scripts/rpm/setup_21.x, scripts/rpm/setup_22.x, scripts/rpm/setup_23.x, scripts/rpm/setup_24.x, scripts/rpm/setup_25.x, scripts/rpm/setup_current.x, scripts/rpm/setup_lts.x
Extended RPM-based system detection logic to recognize /etc/openEuler-release, allowing OpenEuler systems to pass validation checks alongside existing Red Hat and Amazon Linux detection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add node25 scripts #1891: Modifies the same RPM setup scripts, particularly scripts/rpm/setup_current.x, with Node 25-related additions that overlap this PR's code paths.
  • Add support for node 24 #1862: Updates .github/workflows/ci.yaml with Node 24 workflow matrix changes, similarly affecting CI configuration touched in this PR.

Suggested reviewers

  • riosje
  • edsadr

Poem

🐰 OpenEuler joins the fold, so swift and clean,
Release files checked with logic keen,
RPM scripts unified as one,
Ten setup paths now all done! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add openEuler OS support for RPM-based distributions' directly and concisely describes the primary change across the entire changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant