Feature/blockquote extra line height#76
Merged
luca-chen198 merged 2 commits intoJun 20, 2026
Merged
Conversation
Add BlockquoteStyle struct with extraLineHeight property following the existing ListStyle pattern. Wire it into styleBlockquote so blockquote line height can be tuned independently.
Member
|
gj |
luca-chen198
added a commit
that referenced
this pull request
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
BlockquoteStyle.extraLineHeightconfiguration option to control line spacing inside blockquotes, following the existing patterns ofListStyle.extraLineHeightandParagraphStyle.lineHeightExtraSpacing.Problem
Blockquote lines currently use the font's natural line height with no way to add breathing room. Paragraphs have
lineHeightExtraSpacingand lists haveextraLineHeight, but blockquotes have no equivalent — making them visually tighter than surrounding content when extra spacing is desired.Changes
BlockquoteStylestruct with a singleextraLineHeight: CGFloatproperty (defaults to0, preserving existing rendering)styleBlockquoteinMarkdownASTStyler.swiftsominimumLineHeight/maximumLineHeightusebaseLineHeight + config.blockquote.extraLineHeight[Unreleased]Non-changes
No external dependencies. No new protocol or service. No test changes (the existing 90 tests pass; the change is additive and covered by existing block styling test coverage).