Merged
Conversation
Contributor
Author
|
@jasonkarns if this looks good then I think it would be a nice addition would be to surface the I was thinking either as part of the node-build install script or maybe just as part of the Homebrew formulae. LMK if you have a preference. |
Member
|
@mfdj thank you for this!!! Gonna think a bit more on the env-var "notes" in your comment. Would you mind opening a separate issue for that? |
Contributor
Author
|
Would love to land this related follow on :-D #721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing nodenv via Homebrew I noticed that node-build dependency didn't include the install hook added by #455.
This PR attempts to rectify this.
Not sure if the convention is correct but I took a stab at it and included the
etcfolder in the install script because it's used by the Homebrew formulae:https://github.com/Homebrew/homebrew-core/blob/4516ee029aac77079a6b1368d8d5402ed573a94b/Formula/node-build.rb#L14-L17