Resolved an issue preventing plugin from working correctly#2
Open
CheapDevotion wants to merge 1 commit intonode-ci:masterfrom
Open
Resolved an issue preventing plugin from working correctly#2CheapDevotion wants to merge 1 commit intonode-ci:masterfrom
CheapDevotion wants to merge 1 commit intonode-ci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of chokidar that is installed with
npm installno longer passes an fs.stat object as a second parameter, so it was impossible for the plugin to determine the type of update event for the project, and in most cases would never reload a changed project. This pull request refactors the plugin a bit so it will work as intended.