Fix invalid regexp in total_geo by escaping +#443
Merged
noctuid merged 1 commit intonoctuid:masterfrom Feb 24, 2026
Merged
Conversation
Owner
|
What is gawk for you? The current code works fine for me (GNU Awk 5.3.2). Escaping also works, so I'm fine with this, but I'm curious why this happening for you and not me. |
Contributor
Author
|
I'm on GNU Awk 5.4.0, API 4.1. Seems like gawk might have changed their regex syntax? |
Contributor
Author
|
Checking the NEWS file for the 5.4.0 release I see this: This is probably what's causing the problem. Please let me know what solution you would prefer and I'll look into it. |
Owner
|
Great, thanks for looking into this. Since this works on the old engine as well, it makes sense to go ahead and switch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex used in
total_georesults in the follow error:Which causes the window to not resize or position itself correctly.
This is easily fixed by escaping the
+twice.