[backend] Add a new file provider to reference external files#274
Open
[backend] Add a new file provider to reference external files#274
Conversation
67f023a to
ac4d5ab
Compare
Contributor
|
I like this design. Uploading a JSON blob feels a bit hacky, but I haven't been able to think of an alternative that doesn't compromise somewhere else. I think it'd be good to add some comments explaining that the uploaded "file" is just arbitrary data to be processed by the file provider. |
ac4d5ab to
2f13661
Compare
6e7074d to
c4a5262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new "external" file provider, allowing challenges to reference files hosted on external URLs. This is useful for large files or files that are already hosted elsewhere.
To support this, the file service has been refactored:
summarizeFileutility to calculate the hash and size from the upload stream.url,hash, andsize.see #273