chore: Use accountId in RoleBindings instead of user#417
Open
daniel-zelazny wants to merge 2 commits into
Open
chore: Use accountId in RoleBindings instead of user#417daniel-zelazny wants to merge 2 commits into
daniel-zelazny wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The user field in RoleBinding specifications has been deprecated in favor of the more semantically correct accountId field.
Summary
This PR updates RoleBinding test fixtures to use accountId instead of the deprecated user field. The nobl9-go SDK dependency is upgraded to version 0.122.0-rc5, which includes native support for the accountId field. Test data in test/inputs/get/rolebindings.yaml has been updated to demonstrate both the new accountId field and a backward compatibility case with the deprecated user field.
Tests
e2e tests run: https://github.com/nobl9/sloctl/actions/runs/21289751208